Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reader for L1C data from the MSI instrument aboard EarthCARE #2803

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented May 22, 2024

This PR adds support for Level 1C (regridded) data produced by the MultiSpectral Imager (MSI) aboard the ESA/JAXA EarthCARE mission.

Currently, the pre-launch test data is supported and it's likely that some small changes will be required once the satellite is operational. For now, all existing MSI data works with the reader.

IMPORTANT NOTE: Both the Sentinel-2 and EarthCARE missions have sensors named 'MSI'. Therefore, I've also made some small changes to the S2/MSI reader in this PR in order to delineate between the two mission sensors.

  • Tests added
  • Fully documented

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.96%. Comparing base (3b9c04e) to head (00d5144).
Report is 255 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2803      +/-   ##
==========================================
+ Coverage   95.95%   95.96%   +0.01%     
==========================================
  Files         379      381       +2     
  Lines       53888    54026     +138     
==========================================
+ Hits        51708    51846     +138     
  Misses       2180     2180              
Flag Coverage Δ
behaviourtests 4.08% <0.00%> (-0.02%) ⬇️
unittests 96.06% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented May 22, 2024

Pull Request Test Coverage Report for Build 9191585206

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 96.043%

Totals Coverage Status
Change from base Build 9157044280: 0.01%
Covered Lines: 51718
Relevant Lines: 53849

💛 - Coveralls

@yukaribbba
Copy link
Contributor

If you change the sensor name you may also need to make the relative changes on pyspectral/zenodo rsr files. Otherwise there'll be an inconsistent warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants